New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mz_* API in Windows shared library #477
base: develop
Are you sure you want to change the base?
Conversation
8e5a839
to
c0ba1d9
Compare
99df9bf
to
1561db3
Compare
cbf6f5a
to
1a7e7e4
Compare
Would it be possible to go forward with this? Both zip reader and zip writer allow to retrieve the underlying zip handle, but in case of a shared library build on Windows one is then unable to actually do anything with the zip object. Moreover, if one prefers to use zip handles over the zip reader and zip writer, then again the shared library build on Windows is not an option. |
Zip object also exposes Stream object, so we would need to export all those functions as well. Why not on Windows just use the command |
Just my 2 cents here:
If these two things were improved/fixed, at least for our use case we would be able to get away with using the higher level interfaces of reader and writer, and no additional exports would be needed. |
|
Sorry, I was wrong, it is only the functions in mz_compat.h that are exported.
|
|
24ede39
to
318e848
Compare
side note, would u help review changes to the vcpkg port to allow export of MZ_* API on windows? |
e16a0be
to
4bfd046
Compare
Needs a rebase. I just ran into this. |
6dea8cc
to
1a2b512
Compare
a5f9e0b
to
162ba6a
Compare
No description provided.