add typescript definitions

[forivall]

The focus of this PR is to add type definitions for typescript. Minimum typescript version supported is 3.0.0 (as figgy pudding is very fancy)

This PR adds documentation for other and one extra test for this in forEach. These changes can be split into other PRs if you want to review them separately.

[zkat]

I find it strange to include types but not include a test that makes sure they pass.

Conversely, I find myself feeling kind of annoyed at the idea of having to deal with these type definitions myself when changing things or adding features. Seeing as I don't use TS for anything else right now, I'm having feelings that this would end up just becoming a maintenance burden for me once your PR lands.

[forivall]

Cool, I'll submit it to definitelyTyped then! I'll clean up the PR so it's just the documentation and improved test.

On Thu., Sep. 13, 2018, 1:37 a.m. Kat Marchán, ***@***.***> wrote: ***@***.**** commented on this pull request. I find it strange to include types but not include a test that makes sure they pass. Conversely, I find myself feeling kind of annoyed at the idea of having to deal with these type definitions myself when changing things or adding features. Seeing as I don't use TS for anything else right now, I'm having feelings that this would end up just becoming a maintenance burden for me once your PR lands. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAuZjHFYXAsHU9-OksjRaASrB_fAUIfBks5uahlagaJpZM4WmUrB> .

-- ~ Emily Marigold Klassen Sent over RFC 1149

[nickytonline]

You can use the tsd package to test the types. See fregante/intervalometer#1 for an example. You could put them in DefinitelyTyped if you feel they'll become a burden.

[nickytonline]

Having said that, I'm sure people would update them for you in your own repo. Another option, if you're open to it, is to just convert the project to TypeScript.