-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZStream scalajs readFile #8853
ZStream scalajs readFile #8853
Conversation
@@ -214,6 +214,22 @@ object ZStreamPlatformSpecificSpec extends ZIOBaseSpec { | |||
} yield assert(isDone)(isFalse) && | |||
assert(exit.untraced)(failsCause(containsCause(Cause.interrupt(selfId)))) | |||
} | |||
) | |||
), | |||
test("ReadFile should work") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test when a file is non-existent?
Looks like the CI is failing for JS. Please fix |
dec3ff5
to
f17f02e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us know when this is ready for a final review (it's marked as Draft
).
f17f02e
to
c7c1353
Compare
@hearnadam finished addressing CI issue and improved the API by supporting overriding the chunk size. |
ready for review. |
No description provided.