Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build changed docker images after pulling. #784

Merged
merged 1 commit into from May 20, 2017

Conversation

mxl
Copy link
Contributor

@mxl mxl commented May 20, 2017

Problem

Docker images aren't being rebuilt if some of the docker setup is changed (docker/compose#1487).

Solution

Build images with docker-compose build after pulling them with docker-compose pull. Unchanged image layers should be reused from cache.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@mxl
Copy link
Contributor Author

mxl commented May 20, 2017

@juliano has an issue with running MS SQL Server setup in #731 because it tries to run setup.sh using old image where SQL Server packages are not installed. We need to merge this before #731.

@mxl mxl mentioned this pull request May 20, 2017
5 tasks
Copy link
Collaborator

@juliano juliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliano
Copy link
Collaborator

juliano commented May 20, 2017

Thanks @mxl, this will save my pr!

@mxl mxl requested review from gustavoamigo and mosyp May 20, 2017 21:58
@mosyp mosyp merged commit 23893f2 into zio:master May 20, 2017
@mxl mxl deleted the build-docker-images branch May 20, 2017 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants