ZValidation: add toEitherException, toFuture and make toTry not discard errors #803
Conversation
| final case class Success[+W, +A](log: Chunk[W], value: A) extends ZValidation[W, Nothing, A] | ||
|
|
||
| object Failure { | ||
| final case class Exception[+W, +E](failure: Failure[W, E])(implicit ev: E <:< Throwable) |
There was a problem hiding this comment.
We're exposing a lot of implementations details here and we are also potentially creating some inaccurate information. The returned Throwable is a subtype of RuntimeException even though it is possible that none of the original throwable are subtypes of RuntimeException. I would suggest we just take the first error and then add the others as suppressed exceptions to that, discarding the log. There are a variety of other operators that users can use to get the log if they want.
There was a problem hiding this comment.
You mean to mutate an existing Exception by adding others as suppressed? Wouldn't that be a bit misleading? How could users recognize the original suppressed exceptions in that particular Exception from those that we would add?
Or do you think it would be better to use a mere Exception instead of RuntimeException.
I don't have a strong opinion on this, so let me know, if you still think adding rest as suppressed to the first one is the best way to go.
Related issue #791
Lighter version of these PRs:
closes #610
closes #603