Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added null or blank and exact match type to int, long and date issue#821 #824

Merged
merged 3 commits into from May 1, 2024
Merged

added null or blank and exact match type to int, long and date issue#821 #824

merged 3 commits into from May 1, 2024

Conversation

vikasgupta78
Copy link
Collaborator

@vikasgupta78 vikasgupta78 commented Apr 23, 2024 •
edited

added null or blank and exact match type to int, long and date issue #821

@vikasgupta78 vikasgupta78 mentioned this pull request Apr 23, 2024
Closed
sonalgoyal
sonalgoyal requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@sonalgoyal sonalgoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be able to templatize the checknullfunction as well as the similarityfucnton so it can be used with any data type

@vikasgupta78
Copy link
Collaborator Author

we should be able to templatize the checknullfunction as well as the similarityfucnton so it can be used with any data type

done in commit ba3503f

@vikasgupta78 vikasgupta78 merged commit e8e4c06 into zinggAI:enterprise May 1, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonalgoyal sonalgoyal sonalgoyal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vikasgupta78 @sonalgoyal