Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#76 Fix Type to be correct in Assert bsz % 2 #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#76 Fix Type to be correct in Assert bsz % 2 #106

wants to merge 1 commit into from

Conversation

graykode
Copy link
Contributor

@graykode graykode commented Jul 3, 2019

#76

I had missed that bsz is Tensor type, not interger...
So I edit assert from before relative_positional_encoding function.

@graykode graykode changed the title #76 Type to be correct #76 Fix Type to be correct Jul 4, 2019
@graykode graykode changed the title #76 Fix Type to be correct #76 Assert Fix Type to be correct Jul 9, 2019
@graykode graykode changed the title #76 Assert Fix Type to be correct #76 Fix Type to be correct in Assert bsz % 2 Jul 9, 2019
@bzantium
Copy link

bzantium commented Jul 9, 2019 •
edited

I also fixed the same issue as: 7ef2f2d!

@graykode
Copy link
Contributor Author

graykode commented Jul 9, 2019

@bzantium Thanks for checking that

@graykode graykode closed this Jul 9, 2019
@graykode graykode reopened this Jul 10, 2019
vochicong referenced this pull request Oct 8, 2019
@bzantium
fix assertion for even number of batch size
7ef2f2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@graykode @bzantium