New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy fixes #49

Open

matthiasbeyer wants to merge 106 commits into zesterer:master from matthiasbeyer:clippy-fixes

Contributor

matthiasbeyer commented Mar 10, 2023

WIP!!!

This is a WIP effort to fix all clippy fixes in the project. It is based on #48, so that PR should clearly go in first, I will then rebase this one.

It is nowhere done, there's a lot reported by clippy. I am just opening this so that you can see what I am doing 😅

matthiasbeyer added 8 commits

March 10, 2023 08:48


          Add default rustfmt config

dc578d1

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Run cargo-fmt

77d74f6

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Run clippy-fix: Mark variables as unused

c97f558

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Run clippy-fix: Remove "mut" keyword where unnecessary

d80876d

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Run clippy-fix: Remove unused imports

37a989e

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove needless borrow

98cab60

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Type with len() fn should also have is_empty()

28a837f

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: use to_string() instead of format!() macro

415ddc4

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

netlify bot commented Mar 10, 2023 •

edited

✅ Deploy Preview for thriving-beignet-855860 ready!

Name	Link
🔨 Latest commit	`09daafb`
🔍 Latest deploy log	https://app.netlify.com/sites/thriving-beignet-855860/deploys/640b058083eb0400085a310c
😎 Deploy Preview	https://deploy-preview-49--thriving-beignet-855860.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

matthiasbeyer added 21 commits

March 10, 2023 11:24


          Fix clippy: Use is_empty() instead of len() == 0

c00f062

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove needless borrow

c43085f

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Replace format!() with to_string() call

180e7db

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Mask unused variable

8de1deb

This variable is only used in the recursion. We cannot easily remove it,
because other trait implementations might need it (any this isnt
supposed to be a refactoring, but only a clippy cleanup).

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Mask unused variable

1bb82f0

This variable is only used in the recursion. We cannot easily remove it,
because other trait implementations might need it (any this isnt
supposed to be a refactoring, but only a clippy cleanup).

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Use is_empty() instead of len() > 0

5acbdbc

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unnecessary keyword "return"

775e025

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unnecessary borrow

ac8960f

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unnecessary clone()

8ff143b

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Elide lifetimes

d2998e0

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Replace into_iter() with iter()

1e1d359

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unnecessary clone()

9630ce3

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unnecessary closure

3ff7f42

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix: Do not use ? operator when we can easily map()

21472c9

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Clippy: Allow result_unit_err lint for now

0fb0f52

Allow this lint for now, so we can fix the simpler ones first and don't
have to scroll in the clippy output all the time.

This patch will be reverted as soon as possible.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Clippy: Allow type_complexity lint for now

Allow this lint for now, so we can fix the simpler ones first and don't
have to scroll in the clippy output all the time.

This patch will be reverted as soon as possible.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unnecessary borrow

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Don't pass unit to function

830f22d

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Use try_for_each instead of collecting to Result

efdd42c

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Don't compare to Ok(()), is is_ok()

0553ddb

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Don't use else-if when logical OR is possible

99609ae

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

matthiasbeyer added 24 commits

March 10, 2023 11:24


          Fix clippy: Remove unnecessary clone()

f2f8206

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Replace len() == 0 with is_empty()

430e975

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Replace into_iter() with iter()

682f1e2

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unused function param

722649c

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Replace find().is_some() with .any()

2084bcb

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unused fn Scope::with()

84c1774

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unused fn Scope::without_basin()

ed5d48f

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unused fn Infer::iter_effects()

60ef0e9

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unused member Datas::alias_lut

05ca379

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix: Allow dead code here

b1c0fea

Not sure whether this is a bug, as all members of this type are unused.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unreachable pattern

626281d

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unreachable pattern

47d248d

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unreachable pattern

8a0fd25

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove feature gate that has been stabelized

92f6e2f

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unnecessary closure

91bf3ef

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Use unwrap_or_default()

770a1f4

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix Clippy: Remove unnecessary closure

7bad21b

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Remove unnecessary clone

4014c39

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Replace or_else() with or()

2ca9618

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Replace format!() with to_string()

6e28f6f

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Replace manual matches!() with macro

85317ee

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Fix clippy: Rename Ident::as_ref()

03514df

This function name could be confused because it is named like
AsRef::as_ref().

Rename this function to Ident::as_string() because it actually does
this.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Clippy: Allow type_complexity lint for now

b89ca84

Allow this lint for now, so we can fix the simpler ones first and don't
have to scroll in the clippy output all the time.

This patch will be reverted as soon as possible.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>


          Allow dead code for now

09daafb

This might be a bug, not sure what to do about it.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

matthiasbeyer force-pushed the clippy-fixes branch from ec0f3f1 to 09daafb Compare

March 10, 2023 10:25

matthiasbeyer marked this pull request as ready for review

March 10, 2023 10:25

Contributor Author

matthiasbeyer commented Mar 10, 2023

Cleaned up, rebased and "clippy-clean" IMO.

#48 should go in first still, though! 😆

matthiasbeyer mentioned this pull request

Open

Owner

zesterer commented Mar 10, 2023

This PR seems to remove several things that were unused, but with intent to use later. While I think clippy is usually a useful tool and very useful on projects in a more mature state, I don't think many of these changes do much to help this particular codebase, with some actually doing it some harm.

zesterer force-pushed the master branch from f0a52ea to 50553fb Compare

September 5, 2023 19:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment