Tente de créer un raccourcis pour que les modo puissent supprimer les mauvais domaines #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mauvais domaines
Arnaud-D
reviewed
Oct 29, 2023
templates/member/profile.html
Outdated
| @@ -856,6 +856,14 @@ <h3>{% trans 'Sanctions' %}</h3> | |||
| {% trans "Confirmer" %} | |||
| </button> | |||
| </form> | |||
| <!-- if the user was banned and he was the first for his mail provider, propose | |||
| quick access to ban provider --> | |||
| {% if profile.user | has_new_provider and can_ban_provider %} | |||
There was a problem hiding this comment.
Je pense que ça serait mieux de remonter cette logique dans le code et pas dans le template. Dans le template, on aurait juste quelque chose du genre {% if show_ban_provider_button %}.
templates/member/profile.html
Outdated
| <!-- if the user was banned and he was the first for his mail provider, propose | ||
| quick access to ban provider --> | ||
| {% if profile.user | has_new_provider and can_ban_provider %} | ||
| <form method="post" action="{% url 'check-new-email-provider' user|get_new_provider_pk %}"> |
There was a problem hiding this comment.
Il y a vraiment besoin d'un filtre ? Des fois qu'il y aurait une méthode (éventuellement à créer), on pourrait faire profile.get_new_provider ou quelque chose du genre. Ça nécessiterait d'utiliser le profil à la place du user par contre.
Arnaud-D
added
C-Front
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Je fais une petite PR pour faciliter le ban des domaines de fournisseurs de membres qui ne se connectent que pou spam.
Aujourd'hui une fois le ban fait, il faut aller sur la page des fournisseur, vérifier que le membre qu'on a banni n'est pas en haut de la liste et bannir si c'est nécessaire.
L'ambition (petite) de cette PR est d'ajouter le bouton directement dans l'interface de profile une fois le membre banni.
Mon environnement étant dans les choux, je n'ai pas pu tester, d'où le brouillon, cependant le code devrait être prêt à être reviewé.