Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more project updates for win ARM64 #2245

Merged
merged 1 commit into from Mar 5, 2024
Merged

more project updates for win ARM64 #2245

merged 1 commit into from Mar 5, 2024

Conversation

glimberg
Copy link
Contributor

@glimberg glimberg commented Mar 5, 2024

No description provided.

@glimberg glimberg requested review from laduke and rcoder March 5, 2024 21:56
laduke
laduke approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@laduke laduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this builds on my arm64 vm

rcoder
rcoder approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@rcoder rcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me; AFAIK we're really the only folks to build ZT1 on Windows on the regular, so bumping the stdlib and VS versions shouldn't impact too many other folks.

@glimberg
Copy link
Contributor Author

glimberg commented Mar 5, 2024

It was just setting ARM64 Debug to match the Release build & other architectures.

@rcoder rcoder merged commit 6be0e67 into dev Mar 5, 2024
5 checks passed
@glimberg glimberg deleted the gl/win-arm64-fix branch March 5, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laduke laduke laduke approved these changes

@rcoder rcoder rcoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glimberg @laduke @rcoder