Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Compress data #9

Open
mauricioabreu opened this issue Jul 12, 2021 · 2 comments
Open

[Feature] Compress data #9

mauricioabreu opened this issue Jul 12, 2021 · 2 comments

Comments

@mauricioabreu
Copy link

Would you accept a PR including a new function used to compress data?

Thank you for this project!

@mauricioabreu mauricioabreu changed the title [Feature] Compress string [Feature] Compress data Jul 12, 2021
@zerkman
Copy link
Owner

zerkman commented Jul 13, 2021

Hi !

This was not in the original scope of this library, but this could be a very interesting improvement.

To remain coherent with the rest of the library, it would have to be written in pure Lua. Did you really do it ?
I think it would be necessary to support versions of Lua from 5.1 to 5.4, for maximum compatibility. LuaJIT only implements Lua 5.1, and the bit32 library, available as standard in Lua 5.1/5.2, is kind of deprecated from Lua 5.3, because of the presence of the new bitwise operators. I can help you with this aspect if necessary.

Thank you too for your interest in this project!

@mauricioabreu
Copy link
Author

@zerkman thank you for the detailed answer.

My idea is to keep your goal to be pure Lua and support the range of versions you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants