kernel: structs: define priq bitmap size via bits per long #72626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaiJuWu
approved these changes
May 12, 2024
andyross
previously approved these changes
May 13, 2024
|
I think this is not enough. If you are changing this to a long, you
should also change the actual bitmap type to a long in `struct _priq_mq`
to match.
|
Correct - let me fix that. |
Since a long is 64-bits on 64-bit architectures, and 32-bits on 32-bit architectures, we can simplify the definition of PRIQ_BITMAP_SIZE by defining it in terms of BITS_PER_LONG. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
cfriedt
force-pushed
the
define-priq-bitmap-size-by-bits-per-long
branch
from
242a649
to
28b9081
Compare
@npitre - Fixed! |
andyross
approved these changes
May 16, 2024
That would be something 😅 I had considered using |
npitre
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a long is 64-bits on 64-bit architectures, and 32-bits on 32-bit architectures, we can simplify the definition of
PRIQ_BITMAP_SIZEby defining it in terms ofBITS_PER_LONG.