Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: drivers: build_all: gpio: fix imx93_evk/mimx9352/a55 #72618

Closed
wants to merge 1 commit into from

Conversation

ycsin
Copy link
Collaborator

@ycsin ycsin commented May 11, 2024

The imx93_evk/mimx9352/a55 board needs a few things enabled to build the gpio test. Add an overlay to enable the required nodes.

Fixes #72619

The `imx93_evk/mimx9352/a55` board needs a few things enabled
to build the gpio test. Add an overlay to enable the required
nodes.

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
@ycsin ycsin marked this pull request as ready for review May 11, 2024 09:15
@ycsin ycsin added bug The issue is a bug, or the PR is fixing a bug Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. labels May 11, 2024
@ycsin ycsin requested a review from dleach02 May 11, 2024 09:28
@ycsin
Copy link
Collaborator Author

ycsin commented May 11, 2024

ping @CkovMk

@CkovMk
Copy link
Contributor

CkovMk commented May 12, 2024

reasonable. @JiafeiPan decided we disable these nodes by default in the board dts.

@ycsin ycsin requested a review from JiafeiPan May 13, 2024 02:08
@JiafeiPan
Copy link
Contributor

Thanks @ycsin to fix this issue, but I would like to use PR #72644 to fix this issue. I.MX93 has onchip GPIO controller, and EVK board also has GPIO expander, the build issue is caused by i2c dts and MFD dts nodes are enabled by expander GPIO driver is not disabled, we need to disable all of them by default. Of course we can enable all of them if we use expaneded GPIO. In fact for onchip GPIO, I have added some overlay for GPIO testing, for example in tests/drivers/gpio/gpio_basic_api/boards/imx93_evk_mimx9352_a55.overlay. Expaned GPIO is used by EVK boards specified functions, don't use them for testing.

Copy link
Contributor

@JiafeiPan JiafeiPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use PR #72644 to fix the issue #72619, thanks.

@JiafeiPan JiafeiPan self-assigned this May 13, 2024
@ycsin
Copy link
Collaborator Author

ycsin commented May 13, 2024

Closed in favour of #72644

@ycsin ycsin closed this May 13, 2024
@ycsin ycsin deleted the pr/build_all_gpio_fix branch May 13, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: GPIO bug The issue is a bug, or the PR is fixing a bug Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imx93_evk/mimx9352/a55 fails build_all/gpio test
4 participants