drivers: spi: add Broadcom iProc QSPI driver #72612
Open
+608
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add device driver, bindings and build-only test for Broadcom iProc QSPI. Signed-off-by: Yong Cong Sin <ycsin@meta.com>
zephyrbot
added
area: Devicetree Binding
tbursztyka
requested changes
May 14, 2024
| spi_context_cs_control(&data->ctx, true); | ||
|
|
||
| do { | ||
| ret = iproc_qspi_xfer(dev); |
There was a problem hiding this comment.
I don't think such advanced controller does not support interrupt mode.
Please, switch to interrupt mode. This is a mandatory requirement.
There was a problem hiding this comment.
Unfortunately this is what we (Meta) have, I think it provides a good starting point to whoever is going to use it, PRs are welcomed to add more features - its open sourced.
Do you think if we can merge this as-is? Otherwise I see no point leaving this PR opened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add device driver, bindings and build-only test for Broadcom iProc QSPI.