scripts: twisterlib: handlers: early QEMU timeout #72610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terminate QEMU earlier if the test finishes and no output data is received for 1 second. This new timeout operates in parallel with the global test timeout. For coverage testing, this can reduce the time spent running individual tests by up to 29 seconds, while still giving the full 30 extra seconds to dump gcov data if needed. Signed-off-by: Jordan Yates <jordan@embeint.com>
zephyrbot
requested review from
gchwier,
golowanow,
gopiotr,
hakehuang,
KamilxPaszkiet,
LukaszMrugala,
nashif and
PerMac
golowanow
reviewed
May 11, 2024
| @@ -879,6 +879,9 @@ def _thread(handler, timeout, outdir, logfile, fifo_fn, pid_fn, | |||
|
|
|||
| while True: | |||
| this_timeout = int((timeout_time - time.time()) * 1000) | |||
| if timeout_extended: | |||
There was a problem hiding this comment.
For coverage testing, this can reduce the time spent
then it should be:
Suggested change
| if timeout_extended: | |
| if timeout_extended and harness.capture_coverage: |
otherwise it will disable extended timeout for non-coverage 'late' output as well
There was a problem hiding this comment.
Coverage is the primary reason for this change, but non-coverage can also benefit in a minor way. Is it likely that any tests print nothing for over a second after the end of the test and then start printing more info that should be captured?
nashif
approved these changes
May 18, 2024
hakehuang
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminate QEMU earlier if the test finishes and no output data is received for 1 second. This new timeout operates in parallel with the global test timeout.
For coverage testing, this can reduce the time spent running individual tests by up to 29 seconds, while still giving the full 30 extra seconds to dump gcov data if needed.
Should reduce the duration of long CI runs like this:
https://github.com/zephyrproject-rtos/zephyr/actions/runs/9036499613/job/24833501514