boards: nxp: frdm_mcxn947: enable USDHC0 #72601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some USDHC IP instances do not have the voltage control bit present, as they can only operate at 3.3V. Move code to select 1.8V mode into a separate helper, and guard the call to UDSHC_SelectVoltage() behind a feature macro from MCUX SDK. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
Remove function for waiting for clock gate, as this is not used anywhere within the USDHC driver. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
Some instances of the USDHC peripheral take longer to reset, and will timeout with the previous delay of 100 cycles. Extend this delay to 1000 cycles to resolve this. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
Add USDHC0 node to the mcxn94x devicetree. This node describes the one instance of the Ultra Secured Digital Host Controller IP present on the MCXN94x series SOCs. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
Add support for USDHC0 controller on FRDM_MCXN947 board. This support was verified using the `tests/subsys/sd/sdmmc` and `tests/subsys/sd/sdio` testcases. Note that this board does not ship with the SD header (J12) populated by default, so the user must populate one. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
zephyrbot
added
platform: NXP
zephyrbot
requested review from
dbaluta,
decsny,
DerekSnell,
EmilioCBen,
manuargue and
yvanderv
|
Reassigning to @dleach02, as this PR only touches NXP drivers/hardware |
henrikbrixandersen
approved these changes
May 12, 2024
dleach02
approved these changes
May 13, 2024
mmahadevan108
approved these changes
May 13, 2024
decsny
reviewed
May 13, 2024
| if SD_STACK | ||
|
|
||
| # SD stack requires larger main stack size | ||
| config MAIN_STACK_SIZE |
There was a problem hiding this comment.
meaning "for most in tree samples" it needs a larger main stack size?
decsny
reviewed
May 13, 2024
| @@ -159,6 +159,14 @@ static void card_detect_gpio_cb(const struct device *port, | |||
| } | |||
| } | |||
|
|
|||
| static void imx_usdhc_select_1_8v(USDHC_Type *base, bool enable_1_8v) | |||
| { | |||
There was a problem hiding this comment.
does this give no warning about empty body?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable support for USDHC0 sd host controller on FRDM_MCXN947. This support was verified with
tests/subsys/sd/sdmmc, andtests/subsys/sd/sdio