lorawan: make possible to send empty frames #72600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
Trivial
zephyrbot
requested review from
JordanYates,
Mani-Sadhasivam,
martinjaeger and
mniestroj
martinjaeger
requested changes
May 10, 2024
subsys/lorawan/lorawan.c
Outdated
| @@ -595,7 +595,7 @@ int lorawan_send(uint8_t port, uint8_t *data, uint8_t len, | |||
| int ret = 0; | |||
| bool empty_frame = false; | |||
|
|
|||
| if (data == NULL) { | |||
| if (len && data == NULL) { | |||
There was a problem hiding this comment.
I'd suggest to make the len check more explicit and swap the conditions, so that the second condition doesn't have to be evaluated in most cases:
Suggested change
| if (len && data == NULL) { | |
| if (data == NULL && len > 0) { |
There was a problem hiding this comment.
Thanks for the suggestion, I have just updated my PR.
The |
Empty frames are allowed by the LoRaWAN protocol and are actually useful to open new RX slots or flush MAC commands in stack. Therefore allow the data pointer to be NULL if len is 0. Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
aurel32
force-pushed
the
lorawan-send-empty-frames
branch
from
e76ee0b
to
1a5e412
Compare
JordanYates
approved these changes
May 11, 2024
ubieda
approved these changes
May 11, 2024
martinjaeger
approved these changes
May 11, 2024
kartben
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty frames are allowed by the LoRaWAN protocol and are actually useful to open new RX slots or flush MAC commands in stack. Therefore allow the data pointer to be
NULLiflenis 0.Note that I am not even sure we want to have this check. It seems in other subsystems, it is the responsibility of the caller to ensure the data pointer is not NULL.