toolchain: llvm: Allow TLS when using llvm targeting arm #72596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TLS for Arm targets seems to be well supported in clang/lld, so mark it as supported by the toolchain. Signed-off-by: Jonathon Penix <jpenix@quicinc.com>
zephyrbot
added
Trivial
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm,
stephanosio and
tejlmand
stephanosio
approved these changes
May 13, 2024
tejlmand
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS for Arm targets seems to be well supported in clang/lld, so mark it as supported by the toolchain.
For testing, I ran twister locally using llvm targeting the qemu_cortex_m3 board as below and did not see any regressions:
west twister -c -W -p qemu_cortex_m3 -x=CONFIG_LLVM_USE_LLD=y -x=CONFIG_COMPILER_RT_RTLIB=y