New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples/littlefs: Fix rcar boards selecting Flash API #72594
samples/littlefs: Fix rcar boards selecting Flash API #72594
Conversation
with these changes sample doesn't work:
results without your commit:
maybe I've used wrong command for building, here what I've used:
|
|
||
CONFIG_DISK_ACCESS=y | ||
CONFIG_DISK_DRIVERS=y | ||
CONFIG_DISK_DRIVER_MMC=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after these changes we use CONFIG_DISK_DRIVER_SDMMC
+ CONFIG_DISK_DRIVER_MMC
(enabled by disk mmc node) and this produces issue
I: LittleFS version 2.8, disk version 2.1
E: Storage init ERROR!
E: fs mount error (-22)
@@ -6,12 +6,3 @@ | |||
CONFIG_MAIN_STACK_SIZE=4096 | |||
CONFIG_COMMON_LIBC_MALLOC_ARENA_SIZE=8192 | |||
CONFIG_FS_LITTLEFS_FC_HEAP_SIZE=8192 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these configs aren't applied at all with build command:
west build -p always -b rcar_h3ulcb/r8a77951/a57 samples/subsys/fs/littlefs -- -DCONF_FILE=prj_blk.conf
Review finished. |
6ff0d56
to
5c3eb80
Compare
The rcar boards use block variant of LittleFS and Disk Access API, but have been using proj.conf for Flash API based access. The commit adds section building boards with pro_blk.conf into sample.yaml, where rcar boards will now be allowed, and removes redundant configuration lines from board specific conf files. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
5c3eb80
to
0cb828d
Compare
Checked changes, everything works nicely. |
The rcar boards use block variant of LittleFS and Disk Access API, but have been using proj.conf for Flash API based access. The commit adds section building boards with pro_blk.conf into sample.yaml, where rcar boards will now be allowed, and removes redundant configuration lines from board specific conf files.