twister: Refactor 'recording' feature and enable it for Ztest and Pytest #72593
+94
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
gchwier,
gopiotr,
hakehuang,
KamilxPaszkiet,
LukaszMrugala,
nashif and
PerMac
hakehuang
reviewed
May 11, 2024
| self.recording.extend(recording) | ||
|
|
||
| filename = os.path.join(self.build_dir, "recording.csv") | ||
| with open(filename, "at") as csvfile: |
There was a problem hiding this comment.
why not just use 'w' mode, if I run the same case multiply times, the output will be confused
Refactor Twister 'recording' feature moving it from Handler class to TestInstance class and enable it also for other Harness child classes other than Console. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Extend Pytest Harness to support 'recording' feature to parse test log by a regular expression and collect as records the same way as Console Harness do. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
golowanow
force-pushed
the
twister_pytest_recording_20240510
branch
from
935240c
to
1b818d1
Compare
hakehuang
approved these changes
May 13, 2024
nashif
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Twister
recordingfeature moving it fromHandlerclass toTestInstanceclass and enable for otherHarnesschildclasses other than
Console, e.g.Ztest.Extend
PytestHarness to supportrecordingfeature to parse test log by a regular expression and collect as records the sameway as
ConsoleHarness does.