scripts: compliance: handle multi-line output from pylint #72592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Continuous Integration
area: Coding Guidelines
zephyrbot
requested review from
fabiobaltieri,
jfischer-no,
kartben,
keith-zephyr,
nashif and
stephanosio
Switch from plain text to JSON output in the pylint compliance check in order to handle multi-line messages, which were so far being dropped by the regex. Fixes zephyrproject-rtos#68037. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
JordanYates
approved these changes
May 10, 2024
fabiobaltieri
approved these changes
May 12, 2024
stephanosio
approved these changes
May 12, 2024
keith-zephyr
approved these changes
May 14, 2024
PerMac
added a commit
to PerMac/zephyr
that referenced
this pull request
May 22, 2024
PR zephyrproject-rtos#72592 made pylint to use json2 output format. However, this format is introduced in pylint v3. This commit adds an appropriate setting in the requirements file. Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no>
SebastianBoe
pushed a commit
to SebastianBoe/zephyr
that referenced
this pull request
May 23, 2024
PR zephyrproject-rtos#72592 made pylint to use json2 output format. However, this format is introduced in pylint v3. This commit adds an appropriate setting in the requirements file. Upstream PR: zephyrproject-rtos#73152 Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from plain text to JSON output in the pylint compliance check in order to handle multi-line messages, which were so far being dropped by the regex.
Fixes #68037.