drivers: elcdif: Fix register writting issue in SetPixelFormat #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please help to review this PR please? Thanks. |
trunghieulenxp
force-pushed
the
fix_register_writting_issue
branch
from
b4acfa8
to
0c0fc16
Compare
|
Hi @dleach02, @mmahadevan108, Could you help me to review this PR, please? Because the PR 72930 is dependent on this patch. Thanks. |
danieldegrasse
approved these changes
May 17, 2024
dleach02
approved these changes
May 21, 2024
When setting pixel format, all the previous values of the CTRL1 register, even not related to pixel format, are unwantedly cleared. This leads to some erroneous behaviors, for example, the interrupts will be disabled. Fix it by modifying only the related bits of the CTRL1 register. Signed-off-by: Trung Hieu Le <trunghieu.le@nxp.com> Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
trunghieulenxp
force-pushed
the
fix_register_writting_issue
branch
from
0c0fc16
to
8a2a25b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when setting pixel format, all the previous values of the CTRL1 register, even not related to pixel format, are unwantedly cleared. This leads to some erroneous behaviors, for example, the interrupts will be disabled.
Fix it by modifying only the related bits of the CTRL1 register.
This was also merged to github mcux-sdk: nxp-mcuxpresso/mcux-sdk@84cd686