Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dev to main (v2.1.2) #1460

Merged
merged 3 commits into from
May 20, 2024
Merged

merge dev to main (v2.1.2) #1460

merged 3 commits into from
May 20, 2024

Conversation

ymc9
Copy link
Member

@ymc9 ymc9 commented May 20, 2024

No description provided.

Copy link
Contributor

coderabbitai bot commented May 20, 2024

Walkthrough

Walkthrough

The recent updates involve version upgrades and schema adjustments across different packages. The JetBrains IDE plugin version is incremented from "2.1.1" to "2.1.2". In the zmodel.langium file, references and enum fields now utilize RegularIDWithTypeNames instead of RegularID. Additionally, a new test case has been added in the schema parser tests to handle enum fields with type names.

Changes

File Path Change Summary
packages/ide/jetbrains/build.gradle.kts Updated JetBrains IDE plugin version from "2.1.1" to "2.1.2".
packages/language/src/zmodel.langium Changed ReferenceExpr and EnumField to use RegularIDWithTypeNames.
packages/schema/tests/schema/parser.test.ts Added test case for parsing enum fields named with type names in schema files.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between fea8ec7 and 37f4a3b.
Files ignored due to path filters (15)
  • package.json is excluded by !**/*.json
  • packages/ide/jetbrains/package.json is excluded by !**/*.json
  • packages/language/package.json is excluded by !**/*.json
  • packages/language/src/generated/ast.ts is excluded by !**/generated/**
  • packages/language/src/generated/grammar.ts is excluded by !**/generated/**
  • packages/misc/redwood/package.json is excluded by !**/*.json
  • packages/plugins/openapi/package.json is excluded by !**/*.json
  • packages/plugins/swr/package.json is excluded by !**/*.json
  • packages/plugins/tanstack-query/package.json is excluded by !**/*.json
  • packages/plugins/trpc/package.json is excluded by !**/*.json
  • packages/runtime/package.json is excluded by !**/*.json
  • packages/schema/package.json is excluded by !**/*.json
  • packages/sdk/package.json is excluded by !**/*.json
  • packages/server/package.json is excluded by !**/*.json
  • packages/testtools/package.json is excluded by !**/*.json
Files selected for processing (3)
  • packages/ide/jetbrains/build.gradle.kts (1 hunks)
  • packages/language/src/zmodel.langium (2 hunks)
  • packages/schema/tests/schema/parser.test.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/ide/jetbrains/build.gradle.kts
Additional comments not posted (3)
packages/language/src/zmodel.langium (2)

77-77: Change in ReferenceExpr target type to RegularIDWithTypeNames enhances flexibility in referencing. Ensure all dependent grammar rules and usages align with this broader identifier range.


212-212: Updated EnumField to use RegularIDWithTypeNames for names, aligning with changes in ReferenceExpr. Verify that all enum usages in the model adhere to this new naming flexibility.

packages/schema/tests/schema/parser.test.ts (1)

90-106: New test case enum fields named with type name appropriately checks the parsing of enums with type-based identifiers. Ensure the test covers all edge cases related to type name usage in enums.

@ymc9 ymc9 added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 71a389c May 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants