Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files: add file management action and permission #853

Merged
merged 3 commits into from
May 17, 2024

Conversation

alejandromumo
Copy link
Member

closes #852

  • Add a new action and permission for file management.
  • Fixed signature of lock_edit_record_published_files to accept draft as well as record.

@alejandromumo alejandromumo force-pushed the fix_file_modification_permissions branch from c915a1a to 8e3a8ab Compare May 10, 2024 11:40
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments on naming and if to pass record/draft to the permission check

site/zenodo_rdm/config.py Outdated Show resolved Hide resolved
site/zenodo_rdm/generators.py Outdated Show resolved Hide resolved
@alejandromumo alejandromumo force-pushed the fix_file_modification_permissions branch from 8e3a8ab to f1b199b Compare May 10, 2024 13:01
@slint slint force-pushed the fix_file_modification_permissions branch from f1b199b to 9353d9b Compare May 17, 2024 08:34
* Add a new action and permission for file management.
* Fixed signature of lock_edit_record_published_files to accept draft
  as well as record.
@slint slint force-pushed the fix_file_modification_permissions branch from 9353d9b to 1bf1248 Compare May 17, 2024 08:35
@slint slint merged commit 7c69eb2 into zenodo:master May 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

edit files: allow users to modify files for non-zenodo DOIs
2 participants