Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argilla annotator #2687

Merged
merged 40 commits into from May 16, 2024
Merged

Argilla annotator #2687

merged 40 commits into from May 16, 2024

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented May 9, 2024

Added the third and final (for me, for now 😄) annotator integration (alongside #2655 and #2641), this time for Argilla.

argilla_annotator

This works both locally-deployed and when the annotation instance lives in the cloud (i.e. in the Hugging Face Spaces deployment which they recommend).

I tried including some of the changes that have been made in the other two PRs, but depending on the merge order there might need to be some final tweaks. (Also, there probably can be some final updates to the BaseAnnotator interface at a later date now that I have a far stronger sense of what's needed and what's not (which we didn't have when we first implemented just Label Studio)).

The Argilla team have mentioned that their SDK / interface will be updated to a 2.x version where lots of things will be fixed, at which point we can update this to fit it.

Relates to argilla-io/argilla#4277 and #2579

To do

  • make a note about breaking change to interface
  • Adding datasets should use ‘FeedbackDataset’ as the interface or offer different types

@strickvl strickvl added the enhancement New feature or request label May 9, 2024
@strickvl strickvl added the internal To filter out internal PRs and issues label May 9, 2024
@strickvl strickvl requested review from safoinme and bcdurak May 9, 2024 20:53
Copy link
Contributor

coderabbitai bot commented May 9, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented May 9, 2024

Images automagically compressed by Calibre's image-actions

Compression reduced images by 29.7%, saving 72.39 KB.

Filename Before After Improvement Visual comparison
docs/book/.gitbook/assets/argilla_annotator.png 243.88 KB 171.49 KB -29.7% View diff

213 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

Copy link
Contributor

@bcdurak bcdurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good overall. I left a few small comments.

I see that you have a few more PRs with different annotator flavors. How does the timeline look for all these flavors?

strickvl and others added 2 commits May 14, 2024 10:54
@strickvl
Copy link
Contributor Author

Thanks for these comments @bcdurak. Just waiting for some final reviews (I think from @safoinme and @avishniakov, too?) and then I'd merge all three onto develop. I figured that is the good time to then revise the annotators interface in the 2-week period in between releases, and then we can release all three together at the same time.

@strickvl strickvl requested a review from bcdurak May 14, 2024 18:25
Copy link
Contributor

@bcdurak bcdurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@strickvl strickvl merged commit 5e50a26 into develop May 16, 2024
58 of 59 checks passed
@strickvl strickvl deleted the feature/argilla-annotator branch May 16, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request internal To filter out internal PRs and issues run-slow-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants