New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argilla annotator #2687
Argilla annotator #2687
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 29.7%, saving 72.39 KB.
213 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good overall. I left a few small comments.
I see that you have a few more PRs with different annotator flavors. How does the timeline look for all these flavors?
src/zenml/integrations/argilla/flavors/argilla_annotator_flavor.py
Outdated
Show resolved
Hide resolved
…r.py Co-authored-by: Barış Can Durak <36421093+bcdurak@users.noreply.github.com>
Thanks for these comments @bcdurak. Just waiting for some final reviews (I think from @safoinme and @avishniakov, too?) and then I'd merge all three onto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦭
Added the third and final (for me, for now 😄) annotator integration (alongside #2655 and #2641), this time for Argilla.
This works both locally-deployed and when the annotation instance lives in the cloud (i.e. in the Hugging Face Spaces deployment which they recommend).
I tried including some of the changes that have been made in the other two PRs, but depending on the merge order there might need to be some final tweaks. (Also, there probably can be some final updates to the
BaseAnnotator
interface at a later date now that I have a far stronger sense of what's needed and what's not (which we didn't have when we first implemented just Label Studio)).The Argilla team have mentioned that their SDK / interface will be updated to a 2.x version where lots of things will be fixed, at which point we can update this to fit it.
Relates to argilla-io/argilla#4277 and #2579
To do
Adding datasets should use ‘FeedbackDataset’ as the interface or offer different types