New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send workflow dispatch event to Cloud Plugins repo on release #2633
base: develop
Are you sure you want to change the base?
Conversation
Important Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Quickstart template updates in |
E2E template updates in |
NLP template updates in |
@schustmi is this one good to go? |
@wjayesh I see that you modified the workflow that gets dispatched to only create a tag. Wouldn't it be easier to just create a tag in that repo directly, or is this workflow dispatch event still the way to go? |
@schustmi I wanted to keep the workflow dispatch in place just in case we want to change the implementation in the future. This setup just gives us an easy way to communicate with the other repo. |
I think it's still weird to do it to be honest, if we ever needed this again we could just copy-paste this from stackoverflow, no need to keep that code around. But if we keep it around, we should at least give the workflow a name that resembles what it does.. |
Describe changes
I implemented an addition to the Docker image building workflow to send an event to the
zenml-io/zenml-cloud-plugins
repo when zenml server images are built.This allows us to build new
zenml-cloud-server
images based on top of the latest zenml server images.Testing
I have tested this to send an event to the plugins repo.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes