Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send workflow dispatch event to Cloud Plugins repo on release #2633

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

wjayesh
Copy link
Contributor

@wjayesh wjayesh commented Apr 24, 2024

Describe changes

I implemented an addition to the Docker image building workflow to send an event to the zenml-io/zenml-cloud-plugins repo when zenml server images are built.

This allows us to build new zenml-cloud-server images based on top of the latest zenml server images.

Testing

I have tested this to send an event to the plugins repo.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Copy link
Contributor

coderabbitai bot commented Apr 24, 2024

Important

Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Apr 24, 2024
@wjayesh wjayesh marked this pull request as draft April 24, 2024 06:11
@wjayesh wjayesh marked this pull request as ready for review April 25, 2024 13:47
@strickvl strickvl requested review from avishniakov and removed request for avishniakov April 25, 2024 14:00
@wjayesh wjayesh requested a review from schustmi April 30, 2024 04:08
Copy link
Contributor

Quickstart template updates in examples/quickstart have been pushed.

Copy link
Contributor

E2E template updates in examples/e2e have been pushed.

Copy link
Contributor

NLP template updates in examples/e2e_nlp have been pushed.

@wjayesh wjayesh requested a review from schustmi May 2, 2024 12:36
@wjayesh
Copy link
Contributor Author

wjayesh commented May 14, 2024

@schustmi is this one good to go?

@schustmi
Copy link
Contributor

@wjayesh I see that you modified the workflow that gets dispatched to only create a tag. Wouldn't it be easier to just create a tag in that repo directly, or is this workflow dispatch event still the way to go?

@wjayesh
Copy link
Contributor Author

wjayesh commented May 23, 2024

@schustmi I wanted to keep the workflow dispatch in place just in case we want to change the implementation in the future. This setup just gives us an easy way to communicate with the other repo.

@schustmi
Copy link
Contributor

I think it's still weird to do it to be honest, if we ever needed this again we could just copy-paste this from stackoverflow, no need to keep that code around. But if we keep it around, we should at least give the workflow a name that resembles what it does..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants