Multiple taxes support in ot modules

[piloujp]

Rewrite of Order Total modules, mainly discount modules, to support different modules options and multiple tax classes and rates.
Replace PR #6392
See issue #6425 for more details.
This PR needs PR #6411 and is complementary to PRs #6391 and #6393 and optionally #6394 .
All options concerning calculation have been tested thoroughly. Options for validation are partially tested.

It can't pass actual tests because there is a new array in 'order->info' and some options have been suppressed too.

[drbyte]

Looking at the test failure for Low Order Fee, it appears as though this new code is simply not charging any tax. The price mismatch is the amount of the tax: $43.49 instead of $46.01 ... the difference is $2.52

zencart/not_for_release/testFramework/FeatureStore/LowOrderFees/LowOrderFeeTest.php

Lines 249 to 254 in dac1dbc

	$this->assertStringContainsString('39.99', (string)$response->getContent() );
	$this->assertStringContainsString('2.50', (string)$response->getContent() );
	$this->assertStringContainsString('-$4.00', (string)$response->getContent() );
	$this->assertStringContainsString('2.52', (string)$response->getContent() );
	$this->assertStringContainsString('5.00', (string)$response->getContent() );
	$this->assertStringContainsString('-$46.01', (string)$response->getContent() );

[drbyte]

@piloujp Thanks for all your work on this. .... lots to review!

[piloujp]

Looking at the test failure for Low Order Fee, it appears as though this new code is simply not charging any tax. The price mismatch is the amount of the tax: $43.49 instead of $46.01 ... the difference is $2.52

zencart/not_for_release/testFramework/FeatureStore/LowOrderFees/LowOrderFeeTest.php

Lines 249 to 254 in dac1dbc

	$this->assertStringContainsString('39.99', (string)$response->getContent() );
	$this->assertStringContainsString('2.50', (string)$response->getContent() );
	$this->assertStringContainsString('-$4.00', (string)$response->getContent() );
	$this->assertStringContainsString('2.52', (string)$response->getContent() );
	$this->assertStringContainsString('5.00', (string)$response->getContent() );
	$this->assertStringContainsString('-$46.01', (string)$response->getContent() );

I really don't know, I get 46.01 in my test cart, which is the actual GitHub ZC with only this PR applied.
Settings are as follows:
Shipping(2.5) and low order fee(5) have no tax class.
Group discount of 10% does not include shipping ->-4$
tax is 7%(2.52). Florida zone with store and customer in Florida and tax basis set to 'shipping'.
If I apply a GV of -46.01, result is 0$.

[piloujp]

I found the problem. It is because of the reversed calculation of taxes 'Credit Note' <=> 'Standard' between original code and new one. The problem is probably the same with other test failing. When test is using 'Standard' recalculation, I get the same results if I use 'Credit Note'.

[torvista]

We've rewritten (offline) it in a way that makes orders super flexible and manageable...It pretty much does away with all the pains we're discussing in this PR....but there's a big cost to such a change

Better that time is invested in progress than all the time I see invested/wasted in trying to polish an oSC t*rd that seems to be unfixable with all the price/discount/tax options available.

Break plugins....listen to people complaining about what functionality they have lost....put it on a roadmap....ask people to take on those tasks. Organised progress.

[piloujp]

I do not remember closing this PR. Perhaps it happened when merging with ZC new commits?