find zone id from state where addressbook is broken

[zcwilt]

Note from @scottcwilson - please note this is a confirmed bug found during the investigation of #6008.

[zcwilt]

Note: this seems to work where there shipping tax is not set to store.
needs more work to cover that

[zcwilt]

updated to fix shipping tax where zone id = 0
Still needs a few more tests to cover tax basis = store

[dbltoe]

As stated on the forum, we do not use a dropdown for state in the registration form.
Also, there are no entry_zone_id entries that are 0 except where the country has no states. Then, the 0 is as it should be, correct?

[zcwilt]

@dbltoe On A clean install of Zencart, if I create a customer account in store then it doesn't set the address book entry_zone_id, regardless of whether zones exist or not.

[zcwilt]

@dbltoe as per my post on the thread. Contact me directly at ian@zen-cart.com to see if I can help more directly with your problem

[zcwilt]

A bit more context.
V1.5.8a does not honor the ACCOUNT_STATE_DRAW_INITIAL_DROPDOWN setting if the store has zones based on the country id and on submission to create account will produce a ENTRY_STATE_ERROR_SELECT error

This was fixed at e3c022f
in the v158 branch

however the problem then becomes that with a State text entry the address_book entry_zone_id will be set to zero as create account does not try and match the entered state to a zone.

@lat9 does have a PR that might address this . #6020

However this still doesn't address a more basic problem.

While we can fix code to store a correct entry_zone_id in the address book, there is the possibility that zone information may be removed and rebuilt by the store owner. Relying on the entry-zone_id becomes problematic.

In the order class we already try and account for this.

in the query method we do

    $this->customer['zone_id'] = $this->getCountryZoneId((int)$this->customer['country'], $this->customer['state']);
    $this->delivery['zone_id'] = $this->getCountryZoneId((int)$this->delivery['country']['id'], $this->delivery['state']);
    $this->billing['zone_id'] = $this->getCountryZoneId((int)$this->billing['country'], $this->billing['state']);

and don't rely on the entry_zone_id

It therefore makes sense that cart calculations in checkout do the same thing.