Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centered the search bar to make look more symmetric #426

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mukundsutar
Copy link

Types of changes

What types of changes does your code introduce? Check all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Modified the Search bar to make it look more symmetric.

Final checklist:

Go over all the following points and check all the boxes that apply
If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING guidelines.
  • All tests passed.

Original
Changes

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zen-audio-player-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 8:19am

Copy link
Member

@shakeelmohamed shakeelmohamed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, small change then we’re good to merge.

@@ -233,6 +233,11 @@ a {

.input-search {
height: 50px;
padding-right: 50px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of padding here, let’s adjust it here so we’re consistent with the left side padding:

diff --git a/css/styles.css b/css/styles.css
index 9cac9e2..f6679a1 100644
--- a/css/styles.css
+++ b/css/styles.css
@@ -108,7 +108,7 @@ a {
 #v {
     font-size: 16px;
     margin: 0 auto;
-    padding-left: 50px;
+    padding: 0 50px;
     text-align: center;
     width: 100%;
 }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This raises a broader task about overall cleaning up CSS selectors and not using IDs, but that’s a much bigger code change that’s just a “nice to have” one day.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukundsutar hi, any chance you can revisit this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants