Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #327 Repeat fix #328

Closed
wants to merge 8 commits into from
Closed

Conversation

k----n
Copy link

@k----n k----n commented Oct 5, 2019

Motivation and Context

Types of changes

What types of changes does your code introduce? Check all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Accounts for the edge case where time to resume is 0, repeat is activated, and the video is still the current video being played

Final checklist:

Go over all the following points and check all the boxes that apply
If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING guidelines.
  • All tests passed.

@k----n
Copy link
Author

k----n commented Oct 5, 2019

Note that this change does not fix the autoplay issue that is resolved in #326

js/everything.js Outdated Show resolved Hide resolved
@shakeelmohamed
Copy link
Member

Will review this when I get a chance, thanks for you effort @k----n

@shakeelmohamed shakeelmohamed deleted the branch zen-audio-player:master August 9, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeat track does not repeat when clicking towards end of song
2 participants