Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat track does not repeat when clicking towards end of song #327

Open
4 tasks done
k----n opened this issue Oct 5, 2019 · 9 comments
Open
4 tasks done

Repeat track does not repeat when clicking towards end of song #327

k----n opened this issue Oct 5, 2019 · 9 comments

Comments

@k----n
Copy link

k----n commented Oct 5, 2019

Bug/issue:

  • Start playing the song
  • Activate the repeat track function
  • Click towards very end of the song
  • Song will not repeat
@vandanmshah
Copy link

vandanmshah commented Oct 25, 2019

@shakeelmohamed I have started working on this...

@k----n
Copy link
Author

k----n commented Oct 26, 2019

@vandanmshah Please look at my PR #328 first and see if it's fixed. I think it's been solved, but it just hasn't been really tested yet.

@vandanmshah
Copy link

@k----n Checked your fix and i am not sure this will work because actually the problem is once you end the player explicitly it loses the timeupdate EventListener, so after that this code is not going to execute, but will take your branch in local and will test it...

@k----n
Copy link
Author

k----n commented Oct 26, 2019

@vandanmshah Okay, I see what you mean. I added something for the 'ended' EventListener and enabled/disabled plyr's 'loop' option, and it seems to sort of fix it. I feel like some of the code isn't needed though...

What's not working now is that when you try to reproduce this bug, the play/pause doesn't update sometimes.

Let me know how your fix goes, interested in knowing what the outcome is!

@vandanmshah
Copy link

@k----n Okay i also did same thing now this will work you can carry on with this fix... I am closing my PR...

Thanks...

@vandanmshah
Copy link

@k----n I will look into it if you want?

@k----n
Copy link
Author

k----n commented Oct 26, 2019

@vandanmshah Please do! I haven't really looked into why the play/pause button doesn't update.

Maybe submit a PR to my branch? https://github.com/k----n/zen-audio-player.github.io/tree/repeat-fix

@SimonRosengren
Copy link

Is this still an issue? It only seems to happen if you fast forward to the very last second of the file at the moment. Was this always the issue?

@shakeelmohamed
Copy link
Member

@SimonRosengren I guess that's the bug, it only happens when clicking near the end of the track. can you help test #328?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants