Change linker script so gGameOverTimer can be in z_game_over.c #1939
+64
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fig02
reviewed
Apr 10, 2024
fig02
approved these changes
Apr 10, 2024
AngheloAlf
reviewed
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
gGameOverTimeris placed inz_message_PAL.c, which is wrong, and annoying because we have to manually adjust the padding for other versions. This introducesinclude_data_only_within_rodataandinclude_no_dataspec directives to deal with it instead.Additionally, I removed some ancient commented-out code in mkldscript.c because I didn't want to deal with it.