Name collider fields for "effects" / misc. #1925
Open
+1,071
−1,058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Natural continuation to collider cleanup ( #1427 #1637 ), and some names based on feedback deriving from #1601 (comment)
Names are Best I Could Think Of ™️ , comments and discussion is, as per usual, very welcome!
Collider.colType
/COLTYPE_
->Collider.colMaterial
/COL_MATERIAL_
ColliderElement.elemType
/ELEMTYPE_
->ColliderElement.elemMaterial
/ELEM_MATERIAL_
CollisionCheckInfo.[at|ac]HitEffect
->CollisionCheckInfo.player[AT|AC]HitReaction
ColliderElementDamageInfoAT.effect
toColliderElementDamageInfoAT.playerACHitReaction
and similar with dmgInfoAC/playerATPLAYER_AT_HIT_
,PLAYER_AC_HIT_
enums for these fields' valuesAC
-named constant in "AT" data which is very confusing, but I don't have a better idea at presentColliderElementDamageInfo[AT|AC].dmgFlags
norCollisionCheckInfo.damageEffect
(in contrary to some prior discussion) (because no idea)