EnHy + objects docs #1499
EnHy + objects docs #1499
Conversation
| /* 0x021C */ s16 fidgetTableY[16]; // bodyWiggleY ? | ||
| /* 0x023C */ s16 fidgetTableZ[16]; // bodyWiggleZ ? |
There was a problem hiding this comment.
Im not 100% sure about calling this a "fidget table" in general. I am aware that mm just recently moved to this terminology, but I wasnt around at the time to take part in the conversation.
Guess its ok for now, but will prob want to discuss it on a broader scale at some point in the future.
Can prob remove the the comments on them too
There was a problem hiding this comment.
I'm always down to discuss names, so if we do have other suggestions please just let me know. Removed the comments at least.
| // ENHY_TYPE_DOG_LADY | ||
| // ENHY_TYPE_WOMAN_3 | ||
| case ENHY_TYPE_MAN_1_BEARD: |
There was a problem hiding this comment.
Why are some of these types commented in the switch? If their case isn't here, then the code below wouldn't run?
There was a problem hiding this comment.
Yeah the code doesn't run for those cases. The comments were just there from the original decomp I think. I should probably just remove them.
There was a problem hiding this comment.
I put those comments in, to highlight which types are not there (they are placed in the enum's order)
but yeah feel free to remove 🤷
There was a problem hiding this comment.
I see, could always put the comments in the default case?
Documents EnHy as well as the different objects surrounding it (except os_anime which is large and tbh I didn't feel like documenting all the animtions). Regarding the objects I decided to go with the naming style
gHylian+ attributes, where attributes describe the npc (old/young, man/woman, details describing their head, etc.) . Any suggestions are welcome of course.