New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP: Allow for an LSP extension match on any suffix, not just filename and ext #11322
base: main
Are you sure you want to change the base?
LSP: Allow for an LSP extension match on any suffix, not just filename and ext #11322
Conversation
We require contributors to sign our Contributor License Agreement, and we don't have @nb-midwestern on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may just want to extend path_suffixes
to handle these cases.
Adding a separate configuration option feels weird.
I agree, it seems like a |
Angular shares file extensions with
html
andts
. It is conventional for an angular file to follow the format*.component.html
or*.component.ts
. This PR allows LSP to add an optional Language detection field calledpath_regex
that can be used to sort out duplicate Languages, such as in the case of angular files.Release Notes:
Path_Regex
option for LSP configs