Testing wait ice and plugin effects unloading #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psprint
requested review from
alichtman,
pschmitt and
vladdoster
as code owners
|
@vladdoster @pschmitt: The test works correctly now because:
|
|
@vladdoster @pschmitt @jankatins I've checked that the added test correctly detects bug breaking of the |
…[[ -n $var ]]'. Also test plugin unloading of atload'!…' ice (tracked atload'' ice)
psprint
changed the title
|
@vladdoster @pschmitt @jankatins Added plugin unloading tests (they are based on |
jankatins
reviewed
Dec 22, 2022
|
@vladdoster @pschmitt @alichtman: ping? |
vladdoster
reviewed
Oct 1, 2023
| } | ||
|
|
||
| @test '(un)load-ices' { | ||
| rm -f $ZTMP |
There was a problem hiding this comment.
This should be moved to the setup function.
| } | ||
|
|
||
| @test 'wait-ice-with-condition' { | ||
| rm -f $ZTMP |
There was a problem hiding this comment.
This should be moved to the setup function.
| } | ||
|
|
||
| @test 'wait-ice' { | ||
| rm -f $ZTMP |
There was a problem hiding this comment.
This should be moved to the setup function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've read about the need on testing
waitice. The following could work, but it doesn't. I'm commiting it so that some other eyes might come up with a solution.Motivation and Context
Related Issue(s)
Usage examples
How Has This Been Tested?
Types of changes
Checklist: