Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override ipython repr methods. #1724

Merged
merged 2 commits into from Mar 27, 2024
Merged

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Mar 26, 2024

Closes #1716

This avoids expensive lookups against object stores.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Closes zarr-developers#1716

This avoids expensive lookups against object stores.
@MSanKeys963
Copy link
Member

Thanks, @dcherian.
I've launched the workflows.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (2534413) to head (adaff54).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1724   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files          38       38           
  Lines       14580    14611   +31     
=======================================
+ Hits        14579    14610   +31     
  Misses          1        1           
Files Coverage Δ
zarr/hierarchy.py 100.00% <100.00%> (ø)
zarr/tests/test_hierarchy.py 100.00% <100.00%> (ø)

Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dcherian!

@jhamman jhamman merged commit bad8dd0 into zarr-developers:main Mar 27, 2024
18 checks passed
@dcherian dcherian deleted the ipython-repr branch March 27, 2024 22:55
@dcherian dcherian restored the ipython-repr branch April 5, 2024 02:29
@dcherian dcherian deleted the ipython-repr branch April 5, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ipython repr methods on Group to prevent expensive lookups
4 participants