Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.12 to CI #1719

Merged
merged 4 commits into from Mar 25, 2024
Merged

Add Python 3.12 to CI #1719

merged 4 commits into from Mar 25, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Mar 20, 2024 •
edited by MSanKeys963

Curious if this works now. Will follow up if CI fails.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman
Copy link
Member Author

jhamman commented Mar 25, 2024

@zarr-developers/python-core-devs - this should be ready to go in.

d-v-b
d-v-b approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jhamman jhamman enabled auto-merge (squash) March 25, 2024 16:28
@jhamman jhamman merged commit f4f0b42 into main Mar 25, 2024
21 checks passed
jhamman added a commit that referenced this pull request Mar 26, 2024
@jhamman
Fix release notes (following #1719)
f419682
@jhamman jhamman mentioned this pull request Mar 26, 2024
Merged
MSanKeys963 pushed a commit that referenced this pull request Mar 27, 2024
@jhamman
Fix release notes (following #1719) (#1725)
2534413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

@d-v-b d-v-b d-v-b approved these changes

@MSanKeys963 MSanKeys963 Awaiting requested review from MSanKeys963

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhamman @normanrz @d-v-b