Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow VLenUTF8 to encode a read-only source #515

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow VLenUTF8 to encode a read-only source #515

wants to merge 3 commits into from

Conversation

ivirshup
Copy link

@ivirshup ivirshup commented Mar 12, 2024 •
edited

Allow read-only arrays to be encoded with VLenUTF8

Arguably this should be tested and potentially fixed for all codecs.

Question: Is this implementation fine? I've done very little Cython, so I have no idea if there are any downsides to this.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@pep8speaks
Copy link

pep8speaks commented Mar 12, 2024 •
edited

Hello @ivirshup! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-03-12 20:26:51 UTC

@ivirshup ivirshup marked this pull request as ready for review March 12, 2024 18:20
@ivirshup ivirshup marked this pull request as draft March 12, 2024 18:23
@ivirshup ivirshup marked this pull request as ready for review March 12, 2024 18:25
@ivirshup ivirshup mentioned this pull request Mar 12, 2024
Closed
@ivirshup ivirshup changed the title Vlen readonly Allow VLenUTF8 to encode a read-only source Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VLenUTF8().encode(buffer) fails is buffer is read-only
2 participants
@ivirshup @pep8speaks