Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hint checking with mypy #460

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Aug 26, 2023

This is a starting point to work towards #443. It:

  • Adds configuration to run mypy
  • pre-commit-config.yaml to run the type checking using pre-commit.
  • Fixes type checking errors so that running mypy at least passes on the current code base.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@pep8speaks
Copy link

pep8speaks commented Dec 27, 2023

Hello @dstansby! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 109:33: E261 at least two spaces before inline comment

Line 9:44: E261 at least two spaces before inline comment

Line 4:47: E261 at least two spaces before inline comment

Line 8:25: E261 at least two spaces before inline comment

Comment last updated at 2024-05-07 11:58:59 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants