Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and disable core break extension #8363

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Deprecate and disable core break extension #8363

wants to merge 5 commits into from

Conversation

aryangupta701
Copy link
Contributor

Fixes #8153

@aryangupta701
Copy link
Contributor Author

oh wait, I think I did something wrong. I didn't understand how spider was deprecated from the core https://github.com/zaproxy/zaproxy/pull/7335/files#. Are we keeping the spider in the core in private/protected mode so that it is not accessible from outside?

@thc202
Copy link
Member

thc202 commented Feb 27, 2024

The classes should be kept but deprecated and the extension is no longer added to the CoreFunctionality.

@thc202 thc202 changed the title chore: brk deprecation Deprecate and disable core break extension Feb 27, 2024
@aryangupta701 aryangupta701 force-pushed the brk-deprecation branch 3 times, most recently from a471197 to 054717e Compare March 14, 2024 23:26
@aryangupta701
Copy link
Contributor Author

ready for review

@aryangupta701 aryangupta701 force-pushed the brk-deprecation branch 3 times, most recently from 04412c3 to 945c8ad Compare March 14, 2024 23:44
@aryangupta701 aryangupta701 force-pushed the brk-deprecation branch 2 times, most recently from 0abefe7 to e6cc1e4 Compare March 16, 2024 23:22
@aryangupta701
Copy link
Contributor Author

ready for review

@thc202
Copy link
Member

thc202 commented Mar 21, 2024

Also, please include the break add-on in the weekly:

zaproxy/zap/src/main/weekly-add-ons.json

Line 4 in 02b5c4f

"projects": [

@thc202
Copy link
Member

thc202 commented Mar 22, 2024 •
edited

This will now have to wait for zaproxy/zap-extensions#5213 (and follow up changes in other add-ons).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thc202 thc202 thc202 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Type-Task
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move break functionality to an add-on
2 participants
@aryangupta701 @thc202