Add statistics annotation WIP #8163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
|
I'll check if there's a way to have labeler skip if "enhancement" is already applied. |
kingthorin
reviewed
Nov 2, 2023
Comment on lines
+73
to
+78
| @ZapStatsKey( | ||
| name = "stats.break.hit", | ||
| scope = "global", | ||
| type = "counter", | ||
| description = "The number of times a break point has been hit", | ||
| version = "2.11.0") |
There was a problem hiding this comment.
Can we make it actually replace: Stats.incCounter(ExtensionBreak.BREAK_POINT_HIT_STATS); ?
There was a problem hiding this comment.
To be clear I'm somewhat naive about annotations, I don't know if we can actually put the annotation inline and have it do the action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just implemented one initially for feedback.
If this looks good then will annotate the rest of the core ones.
The add-ons will not be able to use this until after a full release..