Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add sarif report option to zap-baseline #8005

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanBradbury
Copy link

@DanBradbury DanBradbury commented Aug 13, 2023

Part of the required work to officially support Code Scanning integration with action-baseline

Original Issue: zaproxy/action-baseline#63

Will require a change to the action-baseline as well to touch the right files (see PR here for that change)

NOTE: hacked together to just get it to work so there are issues with .json being added to the report name, etc. This PR is just to demonstrate where the changes should be made to add sarif support

@kingthorin
Copy link
Member

kingthorin commented Aug 13, 2023

I'm not sure this is the right way to go about this. We intend to replace the packaged scans with Automation Framework functionality.


To address the DCO requirement you'll need to sign-off the commit(s):

@thc202 thc202 changed the title Add sarif report option to zap-baseline [WIP] Add sarif report option to zap-baseline Aug 14, 2023
@DanBradbury
Copy link
Author

I'm not sure this is the right way to go about this. We intend to replace the packaged scans with Automation Framework functionality.

Would the move be into the new af action? Wondering if there was a known timeline / if we should be rolling our own dictions in the meantime to just leverage zap.sh running with AF configuration

@thc202
Copy link
Member

thc202 commented Aug 14, 2023

Ref #7659

@DanBradbury
Copy link
Author

@thc202 If the plan has been to move to AF then where is the path forward? I dont see any movement on the af-action repo and just want some improvement for the zap-baseline scans that some of us are using.

If there is a desire to move away from the packaged scans can there be some official language added to the support docs to say that this is going to be deprecated and the maintainers have no interest in making updates to fix issues?

@psiinon
Copy link
Member

psiinon commented Aug 14, 2023

We have been a bit busy recently 😁
We are now looking at our future plans and yes, the plans for the actions and packaged scans will be part of this process.

@DanBradbury
Copy link
Author

@psiinon Are there any open issues that members of the community can assist with? I'd personally like to see this project continue to improve and would love to accelerate any of the dev thats keeping you guys bogged down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants