Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoints. #7875

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Breakpoints. #7875

wants to merge 1 commit into from

Conversation

Keindel
Copy link

@Keindel Keindel commented May 23, 2023

In Break add/edit dialog String Field has been splitted into multiple fields: Protocol, Host, Path, Query.

Add request and/or response choice in breaks: choice of break activation on-request and/or on-response is now available.

Add break persisting. Breaks in UI are now consistent with session DB.

@kingthorin
Copy link
Member

Also I believe there's a JSON View available via the Marketplace.

@kingthorin
Copy link
Member

@thc202 thc202 changed the title Breakpoints. [WIP] Breakpoints. May 23, 2023
@Keindel Keindel force-pushed the breaks-pr branch 3 times, most recently from e5fbcc6 to 20fce2c Compare May 24, 2023 09:57
@Keindel Keindel requested review from thc202 and kingthorin May 24, 2023 10:59
@thc202 thc202 removed their request for review May 24, 2023 11:19
@Keindel
Copy link
Author

Keindel commented May 25, 2023

Json formatting is excluded, DCO requirement is satisfied.

@Keindel Keindel changed the title [WIP] Breakpoints. Breakpoints. May 25, 2023
@kingthorin kingthorin removed their request for review May 25, 2023 12:14
@kingthorin
Copy link
Member

  • The commits can be squashed or fixed-up, and signed off for DCO.
  • The code formatting should be consistent. It is syntactically correct, and I'm sure there's other old code where things weren't done 'right' but conditionals should use curly braces even for single statements, etc.

@Keindel Keindel force-pushed the breaks-pr branch 2 times, most recently from 81eda3e to c29db43 Compare May 25, 2023 13:27
@Keindel
Copy link
Author

Keindel commented May 25, 2023

Added null-checks for not yet implemented experimental DB case.
Added instance class checks before DB-related methods call.

New commits are squashed and signed off for DCO.
curly braces even for single statements - fixed

@Keindel Keindel requested review from thc202 and kingthorin May 29, 2023 07:22
@thc202 thc202 removed their request for review May 29, 2023 07:26
@kingthorin kingthorin removed their request for review May 29, 2023 08:44
@Keindel
Copy link
Author

Keindel commented Jun 7, 2023

It seems that neglecting of special chars escaping for breaks UI may affect user workflow.
So I've reverted those changes.

@Keindel Keindel requested a review from kingthorin June 16, 2023 12:18
Split url string into host+path+query.
Add request and/or response choice in breaks.
Add break persisting.

Signed-off-by: Andrey Maksimov <g.andmaximov@gmail.com>
@Keindel
Copy link
Author

Keindel commented Jun 26, 2023

updated header comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants