Do not change directory when running zap
#7781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent the startup script from changing directory. This ensures that any artifacts created by `zap`, such as the output of `-quickout` will land in the current directory instead of the ZAP installation directory. Closes zaproxy#7580
|
Commit needs to be singed-off: https://github.com/zaproxy/zaproxy/pull/7781/checks?check_run_id=11933480536 |
|
This will "break" for those relying on existing behaviour. |
thc202
reviewed
Mar 12, 2023
Comment on lines
+123
to
+127
| JAVADEBUGPORT=`echo "$var" | sed -e "s/--jvmdebug//g" | sed -e "s/=//g"` | ||
| if [ ! "$JAVADEBUGPORT" ]; then | ||
| JAVADEBUGPORT=1044 | ||
| fi | ||
| JAVADEBUG="-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=127.0.0.1:$JAVADEBUGPORT" |
There was a problem hiding this comment.
Better if the indentation changes are done in its own commit.
|
What will be the practical impact of these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the startup script from changing directory.
This ensures that any artifacts created by
zap, such as the output of-quickoutwill land in the current directory instead of the ZAP installation directory.Closes #7580