Fix structural parameters with POST request. #7193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kiy0taka <kiy0taka333@gmail.com>
Signed-off-by: kiy0taka <kiy0taka333@gmail.com>
kiy0taka
force-pushed
the
fix/post-structural-parameters
branch
from
b2ad2e1
to
122cfdb
Compare
|
Thanks - will review this asap... |
* What went wrong:
Execution failed for task ':zap:spotlessJavaCheck'.
> The following files had format violations:
zap/src/test/java/org/zaproxy/zap/model/StandardParameterParserUnitTest.java
@@ -19,6 +19,7 @@
·*/
package·org.zaproxy.zap.model;
+import·static·java.util.Arrays.asList;
import·static·org.hamcrest.MatcherAssert.assertThat;
import·static·org.hamcrest.Matchers.empty;
import·static·org.hamcrest.Matchers.equalTo;
@@ -26,7 +27,6 @@
import·static·org.hamcrest.Matchers.is;
import·static·org.hamcrest.Matchers.nullValue;
import·static·org.junit.jupiter.api.Assertions.assertEquals;
-import·static·java.util.Arrays.asList;
import·java.util.ArrayList;
import·java.util.List;
Run './gradlew :zap:spotlessApply' to fix these violations. |
Signed-off-by: kiy0taka <kiy0taka333@gmail.com>
|
Thanks @kiy0taka |
psiinon
approved these changes
Apr 20, 2022
thc202
reviewed
Apr 20, 2022
| @@ -80,6 +82,53 @@ void defaultParser() { | |||
| assertEquals(res2.get(3).getValue(), "g"); | |||
| } | |||
|
|
|||
| @Test | |||
| void defaultTreePath() throws HttpMalformedHeaderException, URIException { | |||
There was a problem hiding this comment.
Also be good to add one that has both query and form parameters.
There was a problem hiding this comment.
Added test cases using ParameterizedTest.
kiy0taka
force-pushed
the
fix/post-structural-parameters
branch
from
842b7c5
to
c3f7af2
Compare
Signed-off-by: kiy0taka <kiy0taka333@gmail.com>
Signed-off-by: kiy0taka <kiy0taka333@gmail.com>
kiy0taka
force-pushed
the
fix/post-structural-parameters
branch
from
c3f7af2
to
15de3b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With structural parameter
pageand following POST requests:Parameter names are used for nodes, so different values are combined into one node.
Fixed so that parameter values are used for different nodes.
