Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move break functionality to an add-on #8153

Open
Tracked by #8049
thc202 opened this issue Oct 30, 2023 · 6 comments · May be fixed by #8363
Open
Tracked by #8049

Move break functionality to an add-on #8153

thc202 opened this issue Oct 30, 2023 · 6 comments · May be fixed by #8363
Assignees
Milestone

Comments

@thc202
Copy link
Member

thc202 commented Oct 30, 2023

The break functionality does not need be in core and being in an add-on allows to enhance/fix it without the need to wait for a full release.

@thc202 thc202 changed the title Move break functionality to an to an add-on Move break functionality to an add-on Oct 30, 2023
@aryangupta701
Copy link
Contributor

has someone picked this up?
I am willing to pick this

@thc202
Copy link
Member Author

thc202 commented Jan 11, 2024

Do you know what needs to be done?

@aryangupta701
Copy link
Contributor

Yes I have a top view idea of this. We need to create a new add on in zap-extensions and use that in zaproxy using interfaces and remove the actual break implementation in core. As I research more on it, I will take your help if stuck somewhere.

@thc202
Copy link
Member Author

thc202 commented Jan 12, 2024

Not quite for the second part, in the end there will be no break functionality in core (i.e. no interfaces needed). Move the functionality to an add-on and change existing add-ons to use it. We should also discuss if we want third-party add-ons to keep working while the transition happens.

@thc202
Copy link
Member Author

thc202 commented Jan 12, 2024

Worth noting that there are core PRs changing the break functionality.

@aryangupta701
Copy link
Contributor

got it. thank you

@aryangupta701 aryangupta701 linked a pull request Feb 27, 2024 that will close this issue
@thc202 thc202 added this to the 2.15.0 milestone Apr 5, 2024
@thc202 thc202 modified the milestones: 2.15.0, 2.16.0 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants