webuipoc: Restructure for JS framework PoCs #5446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricekot
force-pushed
the
webuipoc/restructure
branch
from
272ce3c
to
949ec18
Compare
kingthorin
reviewed
May 14, 2024
ricekot
force-pushed
the
webuipoc/restructure
branch
from
949ec18
to
c4a3607
Compare
|
Thanks for the PR, is there any special reason for preferring nano-react-app over create-react-app which is more commonly used? |
|
I believe simply to keep things small for the example |
thc202
reviewed
May 14, 2024
thc202
reviewed
May 14, 2024
ricekot
force-pushed
the
webuipoc/restructure
branch
from
c4a3607
to
c8dbe43
Compare
Update the add-on build script to build and package PoCs that use JS frameworks like React and follow a few set guidelines. Include a very minimal React example to demonstrate and test the Gradle task. Signed-off-by: ricekot <github@ricekot.com>
ricekot
force-pushed
the
webuipoc/restructure
branch
from
c8dbe43
to
f9d3a70
Compare
thc202
approved these changes
May 14, 2024
|
Thank you! |
kingthorin
approved these changes
May 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the add-on build script to build and package PoCs that use JS frameworks like React and follow a few set guidelines.
Include a very minimal React example to demonstrate and test the Gradle task.
The react app was generated with nano-react-app and slightly modified.