Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Add support for loadDir action #5445

Merged
merged 1 commit into from
May 16, 2024

Conversation

psiinon
Copy link
Member

@psiinon psiinon commented May 13, 2024

Overview

Add support for loadDir action.
I've gone for the simplest approach - always enable all, not zip support..

Related Issues

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

For more details, please refer to the developer rules and guidelines.

@psiinon
Copy link
Member Author

psiinon commented May 14, 2024

Fixed those, also remembered to update min/max yaml files 😁

@thc202
Copy link
Member

thc202 commented May 16, 2024

Thank you!

@psiinon
Copy link
Member Author

psiinon commented May 16, 2024

@kingthorin or @ricekot - ok with this?


Loads all of the scripts in the subdirectories under the specified source path to ZAP.
Scripts are enabled but not configured to be loaded when ZAP restarts.
<br><br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End paragraph?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, and the HTML I copied from above :)

Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just that one very minor nitpicky item (para vs breaks)

Signed-off-by: Simon Bennetts <psiinon@gmail.com>
@psiinon
Copy link
Member Author

psiinon commented May 16, 2024

Fixed 😁

@kingthorin kingthorin merged commit bf6eef6 into zaproxy:main May 16, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants