paramdigger: Handle session change & previous PR follow-up #5306
Conversation
addOns/paramdigger/src/main/java/org/zaproxy/addon/paramdigger/ExtensionParamDigger.java
Outdated
Show resolved
Hide resolved
| httpSender.sendAndReceive(msg); | ||
| addCacheMessage(msg); | ||
| indicValue = msg.getResponseHeader().getHeader(cache.getIndicator()); | ||
| return this.checkCacheHit(indicValue, cache); |
There was a problem hiding this comment.
It was returning false when true, should have test.
There was a problem hiding this comment.
Will review, and see what I can do/add. I did double check that existing tests passed.
There was a problem hiding this comment.
Agreed the logic was the other way around. However, I can't come up with a test case where it matters 😞
There was a problem hiding this comment.
You mean based on the existing tests?
There was a problem hiding this comment.
Yes, shouldNotFindCacheWithAnyCacheBuster seems to hit one case (always miss true). But, really passes whether or not that block is true or false 🤷♂️
You can validate simply with the following in CacheController around L870:
System.out.println("Here");
return false;//!this.checkCacheHit(indicValue, cache);and
System.out.println("Here");
return true;//!this.checkCacheHit(indicValue, cache);There was a problem hiding this comment.
I will have to check the code/tests.
kingthorin
force-pushed
the
pd-tweaks
branch
from
71aab35
to
cb1b866
Compare
- CHANGELOG > Add change note. - CacheController > Remove unnecessary else block and conditional handling. - ExtensionParamDigger > Add and use SessionChangedListener. - HeaderGuesser > Make constant final. Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
kingthorin
force-pushed
the
pd-tweaks
branch
from
cb1b866
to
230711e
Compare
Overview
Related Issues
Checklist
./gradlew spotlessApplyfor code formatting